Opened 12 years ago
Closed 12 years ago
#6760 closed defect (fixed)
error in quaternion algebra ideal basis
Reported by: | robertwb | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-4.3 |
Component: | algebra | Keywords: | |
Cc: | Merged in: | sage-4.3.alpha0 | |
Authors: | Robert Bradshaw | Reviewers: | Alex Ghitza |
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
sage: R.<i,j,k> = QuaternionAlgebra(-1, -13) sage: I = R.ideal([2+i, 3*i, 5*j, j+k]); I Fractional ideal (2 + i, 3*i, j + k, 5*k) sage: I.free_module() ------------------------------------------------------------ Traceback (most recent call last): File "<ipython console>", line 1, in <module> File "/Users/robert/sage/sage-4.0/local/lib/python2.6/site-packages/sage/algebras/quatalg/quaternion_algebra.py", line 1503, in free_module M = self.hermite_basis_matrix().row_module(ZZ) AttributeError: 'QuaternionFractionalIdeal_rational' object has no attribute 'hermite_basis_matrix'
Attachments (2)
Change History (7)
Changed 12 years ago by
comment:1 Changed 12 years ago by
- Summary changed from error in quaternion algebra ideal basis to [with patch, needs review] error in quaternion algebra ideal basis
comment:2 Changed 12 years ago by
- Summary changed from [with patch, needs review] error in quaternion algebra ideal basis to error in quaternion algebra ideal basis
comment:3 Changed 12 years ago by
- Reviewers set to Alex Ghitza
Looks good to me. I am adding a patch with a doctest (just the example that was given above).
Robert, if you're happy with the second patch, please change this to a positive review.
comment:4 Changed 12 years ago by
- Status changed from needs_review to positive_review
comment:5 Changed 12 years ago by
- Merged in set to sage-4.3.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I think this is the right fix, but someone more familiar with the code should take a look.